Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 修复树状模式当一组数据只有一条数据时, 叶子节点判断错误, 也渲染了展开/收起图标 close #2804 #2806

Merged
merged 2 commits into from
Jul 5, 2024
Merged

fix: 修复树状模式当一组数据只有一条数据时, 叶子节点判断错误, 也渲染了展开/收起图标 close #2804 #2806

merged 2 commits into from
Jul 5, 2024

Conversation

lijinke666
Copy link
Member

@lijinke666 lijinke666 commented Jul 4, 2024 •
edited
Loading

👀 PR includes

🐛 Bugfix

📝 Description

image

树状模式由于一级节点即是普通节点, 又是小计节点, 在当前分组下只有一条数据时, isLeaf 判断错误, 错误的展示了折叠展开 icon.

{
  "fields": {
    "rows": ["row0", "row1"],
    "columns": ["col0"],
    "values": ["cost"],
    "valueInCols": true
  },
  "data": [
    {
      "row0": "a-1",
      "col0": "b-1",
      "cost": 2
    },
    {
      "row0": "a-2",
      "row1": "a-2-1",
      "col0": "b-2",
      "cost": 3
    }
  ]
}

🖼️ Screenshot

Before After
image image

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@vercel Vercel
Copy link

vercel bot commented Jul 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Jul 5, 2024 8:09am

@github-actions github-actions bot added the pr(fix) bug fix label Jul 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added 🚨 test failed 单元测试挂了 🚨 lint failed 静态检查失败 labels Jul 4, 2024
@lijinke666 lijinke666 merged commit fa5bb9b into master Jul 5, 2024
5 of 9 checks passed
@lijinke666 lijinke666 deleted the fix-2804 branch July 5, 2024 08:05
@lijinke666 lijinke666 removed 🚨 test failed 单元测试挂了 🚨 lint failed 静态检查失败 labels Jul 5, 2024
@github-actions github-actions bot removed the 🚨 test failed 单元测试挂了 label Jul 5, 2024
lijinke666 added a commit that referenced this pull request Jul 5, 2024
@lijinke666
fix: 修复树状模式当一组数据只有一条数据时, 叶子节点判断错误, 也渲染了展开/收起图标 close #2804 (#2806)
76a7a59 
fix: 修复树状模式下一组数据只有一条数据时, 叶子节点判断错误, 也渲染了展开/收起图标 close #2804
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v1.55.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjgogogo wjgogogo wjgogogo approved these changes

@wuhaiyang wuhaiyang Awaiting requested review from wuhaiyang

Assignees

@lijinke666 lijinke666

Labels
pr(fix) bug fix released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

透视表树模式根节点没有后代也展示展开/收起图标
2 participants
@lijinke666 @wjgogogo